Skip to content

[GLUTEN-4836][VL] Enable Rank and DenseRank for WindowGroupLimitExec#11567

Merged
zhouyuan merged 10 commits intoapache:mainfrom
zhouyuan:wip_window_enable
Feb 13, 2026
Merged

[GLUTEN-4836][VL] Enable Rank and DenseRank for WindowGroupLimitExec#11567
zhouyuan merged 10 commits intoapache:mainfrom
zhouyuan:wip_window_enable

Conversation

@zhouyuan
Copy link
Member

@zhouyuan zhouyuan commented Feb 5, 2026

What changes are proposed in this pull request?

Enable Rank/DenseRank for WindowGroupLimit
These two functions are supported on Velox backend already

How was this patch tested?

verified with ds-q67
pass GHA with existing check on Window functions

Was this patch authored or co-authored using generative AI tooling?

Related issue: #4836

@github-actions github-actions bot added the VELOX label Feb 5, 2026
@zhouyuan zhouyuan marked this pull request as ready for review February 5, 2026 09:53
@zhouyuan zhouyuan requested a review from JkSelf February 5, 2026 09:54
@zhouyuan zhouyuan changed the title [GLUTEN-4836][VL] Enable Rank and DanseRank for WindowGroupLimitExec [GLUTEN-4836][VL] Enable Rank and DenseRank for WindowGroupLimitExec Feb 5, 2026
@github-actions github-actions bot added the CORE works for Gluten Core label Feb 7, 2026
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Run Gluten Clickhouse CI on x86

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

2 similar comments
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@zhouyuan zhouyuan changed the title [GLUTEN-4836][VL] Enable Rank and DenseRank for WindowGroupLimitExec [GLUTEN-4836][VL] Enable Rank and DenseRank for WindowGroupLimitExec Feb 13, 2026
@zhouyuan zhouyuan merged commit f085450 into apache:main Feb 13, 2026
65 checks passed
ReemaAlzaid pushed a commit to ReemaAlzaid/incubator-gluten that referenced this pull request Feb 14, 2026
…Exec` (apache#11567)

Enable Rank/DenseRank for WindowGroupLimit operator. These two functions are supported on Velox TopNRowNumber

---------

Signed-off-by: Yuan <yuanzhou@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants